Copy request options during tls connection change #10369
Conversation
|
|
CT Test Results 2 files 23 suites 10m 17s ⏱️ Results for commit 74a94a9. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
|
@itssundeep You need to sign the CLA |
IngelaAndin
left a comment
IngelaAndin
left a comment
There was a problem hiding this comment.
I think the change looks sound. And I guess it is sort of complicated to write a test for it. Have you considered it? @Whaileee what do you think could we manage a test case?
|
From what I can tell this case, originating from connect_and_send_upgrade_request isn't covered by our testcases and I feel like it could use some testing. Would you like to try and write a testcase for that @itssundeep? |
|
@Whaileee I am not too familiar on how to simulate the error scenario in the test, so would prefer if someone else would take it up. |
Whaileee
force-pushed
the
httpc_fix
branch
2 times, most recently
from
4b20cf4 to
b0890d3
Compare
|
I've moved the branch to patch-base-27 so it can be easily applied to all affected versions |
- Add "remote" proxy groups
- Add ncat as dummy proxy
5 participants
This should address the issue with #10368